[PATCH] Further relax the constraint on atomics in MemoryDependencyAnalysis.cpp

JF Bastien jfb at chromium.org
Wed Aug 20 21:53:21 PDT 2014


The change looks good overall, but I'd like to have @reames review it too.

================
Comment at: test/Transforms/DeadStoreElimination/atomic.ll:163
@@ +162,3 @@
+  store atomic i32 0, i32* @y release, align 4
+  %x = load atomic i32* @y acquire, align 4
+  store i32 1, i32* @x
----------------
Why not also test load-acq followed by store-rel here and in other places (or the reverse store/load)? It seems like a good sanity check.

================
Comment at: test/Transforms/GVN/atomic.ll:133
@@ -106,1 +132,2 @@
 
+
----------------
Drop the extra space.

http://reviews.llvm.org/D4845






More information about the llvm-commits mailing list