[PATCH] Debug info: Support fragmented variables.

David Blaikie dblaikie at gmail.com
Wed Aug 20 19:50:10 PDT 2014


Bumping this hopefully into Chandler's queue (by setting him as a reviewer, rather than just a subscriber) and some minor feedback from me on the test cases.

================
Comment at: test/DebugInfo/X86/sroasplit-2.ll:8
@@ +7,3 @@
+;
+;    // Compile with -O1
+;    typedef struct {
----------------
Perhaps these two test cases could be named more precisely for what they do - it took me a bit of staring to see the specific difference between them (the type of the Inner::b member is different) and I still don't have any idea why that's important to test separately (what is it that's different about that case)?

(if it is different and different code is needed for it, usual question applies about "is this different code that can be implemented/tested/committed separately", but perhaps it isn't)

& do both cases need the two levels of indirection (a struct, with an array of other structs)? While a test case that covers a few cases in one go is soemtimes nice, it'd help me at least if there was a comment explaining why the different pieces of indirection were important to the test - what parts of SROA they're exercising.

http://reviews.llvm.org/D2680






More information about the llvm-commits mailing list