[PATCH] ARM: Fix codegen for rbit intrinsic

[Yi Kong]

Hi grosbach, rengolin,

LLVM generates illegal `rbit r0, #352` instruction for `llvm.arm.rbit` intrinsic. According to ARMARM, `rbit` only takes register as argument, not immediate. The correct instruction should be `rbit <Rd>, <Rm>`.

The bug was introduced by r211057.

http://reviews.llvm.org/D4980

Files:
  lib/Target/ARM/ARMISelLowering.cpp
  test/CodeGen/AArch64/rbit.ll
  test/CodeGen/ARM/rbit.ll

Index: lib/Target/ARM/ARMISelLowering.cpp
===================================================================
--- lib/Target/ARM/ARMISelLowering.cpp
+++ lib/Target/ARM/ARMISelLowering.cpp
@@ -2642,9 +2642,9 @@
   switch (IntNo) {
   default: return SDValue();    // Don't custom lower most intrinsics.
   case Intrinsic::arm_rbit: {
-    assert(Op.getOperand(0).getValueType() == MVT::i32 &&
+    assert(Op.getOperand(1).getValueType() == MVT::i32 &&
            "RBIT intrinsic must have i32 type!");
-    return DAG.getNode(ARMISD::RBIT, dl, MVT::i32, Op.getOperand(0));
+    return DAG.getNode(ARMISD::RBIT, dl, MVT::i32, Op.getOperand(1));
   }
   case Intrinsic::arm_thread_pointer: {
     EVT PtrVT = DAG.getTargetLoweringInfo().getPointerTy();
Index: test/CodeGen/AArch64/rbit.ll
===================================================================
--- /dev/null
+++ test/CodeGen/AArch64/rbit.ll
@@ -0,0 +1,20 @@
+; RUN: llc -mtriple=aarch64-eabi %s -o - | FileCheck %s
+
+; CHECK-LABEL: rbit32
+; CHECK: rbit w0, w0
+define i32 @rbit32(i32 %t) #0 {
+entry:
+  %rbit.i = call i32 @llvm.aarch64.rbit.i32(i32 %t) #2
+  ret i32 %rbit.i
+}
+
+; CHECK-LABEL: rbit64
+; CHECK: rbit x0, x0
+define i64 @rbit64(i64 %t) #0 {
+entry:
+  %rbit.i = call i64 @llvm.aarch64.rbit.i64(i64 %t) #2
+  ret i64 %rbit.i
+}
+
+declare i64 @llvm.aarch64.rbit.i64(i64) #1
+declare i32 @llvm.aarch64.rbit.i32(i32) #1
Index: test/CodeGen/ARM/rbit.ll
===================================================================
--- /dev/null
+++ test/CodeGen/ARM/rbit.ll
@@ -0,0 +1,10 @@
+; RUN: llc -mtriple=armv8-eabi %s -o - | FileCheck %s
+
+; CHECK: rbit r0, r0
+define i32 @rbit(i32 %t) #0 {
+entry:
+  %rbit = call i32 @llvm.arm.rbit(i32 %t)
+  ret i32 %rbit
+}
+
+declare i32 @llvm.arm.rbit(i32) #1
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D4980.12693.patch
Type: text/x-patch
Size: 1777 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140820/0750942a/attachment.bin>