[compiler-rt] r215295 - builtins: correct __umodsi3, __udivsi3 on ARM

Renato Golin renato.golin at linaro.org
Tue Aug 19 16:50:22 PDT 2014


On 19 August 2014 23:12, Joerg Sonnenberger <joerg at britannica.bec.de> wrote:
> There is certainly C&P involved for the three variations (div, mod,
> div/mod) as they all share the same core algorithm with minor
> variations. I can't say anything about the working state of the idiv
> path as I don't have any hardware for that. I remember asking for
> testers of that. The code was carefully tested for the non-idiv
> branches.

I think I benchmarked it manually, and no corruptions were seen, and I
also ran a full test-suite with compiler-rt, but forgot to check if
the calls were actually being made. I now believe that I was either
very lucky, or LLVM generated DIV instructions instead of calling the
function altogether.

Anyway, thanks everyone for the task force! Crisis averted!

cheers,
--renato



More information about the llvm-commits mailing list