[llvm] r216008 - ADT: Unit test for ArrayRef::equals change in r215986

Duncan P. N. Exon Smith dexonsmith at apple.com
Tue Aug 19 14:11:00 PDT 2014


> On 2014-Aug-19, at 14:05, David Blaikie <dblaikie at gmail.com> wrote:
> 
> On Tue, Aug 19, 2014 at 12:18 PM, Duncan P. N. Exon Smith
> <dexonsmith at apple.com> wrote:
>> Author: dexonsmith
>> Date: Tue Aug 19 14:18:46 2014
>> New Revision: 216008
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=216008&view=rev
>> Log:
>> ADT: Unit test for ArrayRef::equals change in r215986
>> 
>> Modified:
>>    llvm/trunk/unittests/ADT/ArrayRefTest.cpp
>> 
>> Modified: llvm/trunk/unittests/ADT/ArrayRefTest.cpp
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/ADT/ArrayRefTest.cpp?rev=216008&r1=216007&r2=216008&view=diff
>> ==============================================================================
>> --- llvm/trunk/unittests/ADT/ArrayRefTest.cpp (original)
>> +++ llvm/trunk/unittests/ADT/ArrayRefTest.cpp Tue Aug 19 14:18:46 2014
>> @@ -59,4 +59,8 @@ TEST(ArrayRefTest, Equals) {
>>   EXPECT_FALSE(AR1b.equals(3, 4, 5, 6, 7));
>> }
>> 
>> +TEST(ArrayRefTest, EmptyEquals) {
>> +  EXPECT_TRUE(ArrayRef<unsigned>() == ArrayRef<unsigned>());
>> +}
> 
> Do we have inequality & does it have the same bug?
> 

They both forward to ArrayRef::equals, so inequality doesn't add
any coverage.

>> +
>> } // end anonymous namespace
>> 
>> 
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits




More information about the llvm-commits mailing list