[PATCH] [x32] Fix FrameIndex check in SelectLEA64_32Addr

Derek Schuff dschuff at google.com
Tue Aug 19 12:14:11 PDT 2014


thanks; yeah I wasn't sure either. I asked on IRC and the consensus seemed to be to just duplicate if the test is fairly small.

================
Comment at: test/CodeGen/X86/lea-5.ll:47
@@ +46,3 @@
+
+; X32-ALIGN64:   leal	(%rsp,%r{{[^,]*}},4), %eax
+  %0 = load i32* %arrayidx, align 4
----------------
shouldn't this just be X32: ?
you can check it in the same run, and you aren't calling FileCheck with X32-ALIGN64 anyway.

http://reviews.llvm.org/D4929






More information about the llvm-commits mailing list