bug 20542

Tim Northover t.p.northover at gmail.com
Mon Aug 18 06:56:55 PDT 2014


Hi Norman,

On 18 August 2014 14:39, Norman Rink <nrink at broadcom.com> wrote:
> Emailing patch as requested by Nick Lewycky (including test case).

This looks too conservative to me. An iN setcc-like node is going to
return the getBooleanContents of the target. If this is ZeroOrOne then
the transformation is correct. If it's ZeroOrNegativeOne then we want
to look for an xor with -1 instead of 1, but the idea behind the
transformation is still OK.

Or am I missing something?

Cheers.

Tim.



More information about the llvm-commits mailing list