[polly][PATCH] Diagnostic: Provide end-user message for non-affine loop bound errors

[Andreas Simbuerger]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1



On 08/16/2014 07:49 PM, Tobias Grosser wrote:
> On 15/08/2014 00:04, Andreas Simbuerger wrote:
>> --- include/polly/ScopDetectionDiagnostic.h            |  4 + 
>> lib/Analysis/ScopDetectionDiagnostic.cpp           | 12 +-- 
>> .../ScopDetectionDiagnostics/ReportLoopBound-01.ll | 89 
>> ++++++++++++++++++++++ 3 files changed, 100 insertions(+), 5
>> deletions(-) create mode 100644
>> test/ScopDetectionDiagnostics/ReportLoopBound-01.ll
> 
> Nice, thanks a lot.
> 
> One comment. I would avoid to mention 'upper bound' in the error 
> message. I believe we also complicated lower bounds can cause this 
> error. What about:
> 
> "Failed to express number of loop iterations as affine function"
> 
> (This is possibly also not optimal, so feel free to improve)

Sounds good, I will change it.

> 
> Also, thanks a lot for the very nice test case.
> 
> Tobias

- -- 
Andreas Simbürger
University of Passau - Programming Group
http://www.infosun.fim.uni-passau.de/cl/staff/simbuerger/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBAgAGBQJT75qfAAoJELS7a/6Ti2HY0NUH/1R4r3XKoEKWZSMQ57wiagfF
WNSkQRlUc7A9MWJQtdDV8C3wwoTsfflk8pPgPRxh4CbDPqAFL2deCRU1tqKTovB0
m1jucAegOzXGiMcPHFvTNjCMxb2OFp4IKMHS3WJc7edp0aqXxpAtKyUiCNjo1ftR
8vDeiHyAGQll0UIapKThOhQAOQlHDNdFcbDbRmFZtcdownOL1wsw0gR4mDXCh7rK
C39UO2o1divYvF6RLapJ1uB/qGDoH0+t2AhPKgkcGLPf6jCt7N4kF5I64BOrlfrj
Yp4+XwYfr9DDwUQ9tT/TMcYDCvrIYWWDgr1UWQA4tirJaZjxRktYXP4Vf3MCrXM=
=5aog
-----END PGP SIGNATURE-----