[PATCH] [Review Request] A module pass "PromoteHalf"

Owen Anderson resistor at mac.com
Fri Aug 15 14:11:42 PDT 2014


> On Aug 15, 2014, at 11:20 AM, Tim Northover <t.p.northover at gmail.com> wrote:
> 
> The end point is that I think the problems with LLVMContextImpl and
> mutateType are insurmountable. I just cannot see a path to a commit
> that doesn't involve a complete rewrite (even if everyone suddenly
> decided that a modulepass was the right way to do it after all). Given
> that, I think the rewrite should take place in the legalizer, as it
> does for other types.

I share Tim’s concerns.  LLVMContextImpl is designed to be an implementation detail of LLVMContext, and never directly accessed outside of it.  I strongly oppose any patch built around exposing it in other areas.

—Owen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140815/f1142d81/attachment.html>


More information about the llvm-commits mailing list