[PATCH] [Polly] Added arcanist (arc) unit test support

David Blaikie dblaikie at gmail.com
Fri Aug 15 08:54:29 PDT 2014


On Fri, Aug 15, 2014 at 12:51 AM, Johannes Doerfert
<doerfert at cs.uni-saarland.de> wrote:
> Hi grosser, sebpop, simbuerg,
>
>   Thanks to Clemens (hammacher at cs.uni-saarland.de) extension of the
>   arcanist unit test engine, we can run the llvm-lit tests automatically.
>
>   Similar to the linters, aracanist will run all tests for each uploaded
>   commit and asks the commiter for a statements in case unit tests fail.
>
>   To use this feature the unit test engine needs to find the polly build
>   directory. Currently we support the following setups:
>
>     $POLLY_BUILD_DIR (environment variable)
>     <root>/build

If by "<root>" you mean the source root - this ^ (having your build
directory as a subtree of your source directory) is generally a
discouraged build configuration, fwiw.

>     <root>.build
>     <root>-build
>     <root:s/src/build>

This'll be handy - it's almost what I have - though perhaps it could
be expressed more generally as "<root>/../build"? Though maybe that's
got too many false positives.

(I have a whole number of different build configurations under
llvm/src/../build, but I could make one authoritative/default, which
could be handy (eg: I could move my current builds to
llvm/src/../builds and make llvm/src/../build ->
llvm/src/../builds/foo/bar/baz))

Though I don't work on Polly - mostly just thinking about what these
might look like if/when applied to LLVM more generally.

>     <cwd>
>
> http://reviews.llvm.org/D4920
>
> Files:
>   .arcconfig
>   utils/arcanist/LitTestEngine/__phutil_library_init__.php
>   utils/arcanist/LitTestEngine/__phutil_library_map__.php
>   utils/arcanist/LitTestEngine/src/LitTestEngine.php
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>



More information about the llvm-commits mailing list