[llvm] r215634 - Add SPHINX_WARNINGS_AS_ERRORS CMake option to allow warnings to not be

[Sean Silva]

Ok, makes sense.


On Thu, Aug 14, 2014 at 2:40 PM, Dan Liew <dan at su-root.co.uk> wrote:

> On 14 August 2014 21:40, Sean Silva <chisophugis at gmail.com> wrote:
> >
> >
> >
> > On Thu, Aug 14, 2014 at 4:57 AM, Dan Liew <dan at su-root.co.uk> wrote:
> >>
> >> Author: delcypher
> >> Date: Thu Aug 14 06:57:13 2014
> >> New Revision: 215634
> >>
> >> URL: http://llvm.org/viewvc/llvm-project?rev=215634&view=rev
> >> Log:
> >> Add SPHINX_WARNINGS_AS_ERRORS CMake option to allow warnings to not be
> >> treated as errors (which is still the default).
> >
> >
> > This seems to contradict the patch, which seems to make -W the default
> > (SPHINX_WARNINGS_AS_ERRORS=ON by default).
>
> Not really. Before sphinx warnings were always treated as errors. Now
> sphinx warnings can be ignored by setting
> SPHINX_WARNINGS_AS_ERRORS=OFF. So we gain the ability to "allow
> warnings to not be treated as errors".
>
> Admittedly I could of worded the commit log a lot better so it doesn't
> sound like I'm contradicting myself.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140814/7c8f7678/attachment.html>