[PATCH] Instcombine (A|B) ^(A^B) to A&B

David Majnemer david.majnemer at gmail.com
Tue Aug 12 21:44:38 PDT 2014


LGTM with comments addressed.

================
Comment at: test/Transforms/InstCombine/or-xor.ll:141-147
@@ +140,9 @@
+define i32 @test15(i32 %x, i32 %y) {
+  %1 = xor i32 %y, %x
+  %2 = or i32 %y, %x
+  %3 = xor i32 %2, %1
+  ret i32 %3
+; CHECK-LABEL: @test15(
+; CHECK-NEXT: %1 = and i32 %y, %x
+; CHECK-NEXT: ret i32 %1
+}
----------------
All the other tests use names for their instructions, can you please do the same?

http://reviews.llvm.org/D4866






More information about the llvm-commits mailing list