[PATCH] move LLVM_VERSION_PATCH to llvm-config.h

Joerg Sonnenberger joerg at britannica.bec.de
Tue Aug 12 16:25:16 PDT 2014


On Tue, Aug 12, 2014 at 04:18:47PM -0700, Chandler Carruth wrote:
> On Tue, Aug 12, 2014 at 3:41 PM, Dylan Noblesmith <nobled at dreamwidth.org>
> wrote:
> 
> > Since clients shouldn't (and shouldn't be able to)
> > include LLVM's internal config.h header, it was
> > effectively completely useless there.
> >
> > Put it where LLVM_VERSION_MAJOR and LLVM_VERSION_MINOR
> > already are instead.
> >
> 
> But, the whole point was that it is *different*. There shouldn't ever be
> API breaking changes in a patch release? The point of patch releases were
> to apply minimal, targeted fixes for critical bugs. Clients shouldn't be
> aware of them IMO.

They might still want to be able to workaround bugs fixed by those
targeted patches for critical bugs :)

Joerg



More information about the llvm-commits mailing list