[PATCH] Don't upgrade global constructors when reading bitcode

Duncan P. N. Exon Smith dexonsmith at apple.com
Tue Aug 12 10:09:11 PDT 2014


> On 2014-Aug-11, at 19:39, Nick Lewycky <nlewycky at google.com> wrote:
> 
>> On 11 August 2014 19:13, Duncan P. N. Exon Smith <dexonsmith at apple.com> wrote:
>> 
>> I guess I'm conservative, but I feel like C API users might be using
>> global constructors and might care.
> 
> As far as I'm aware, this is the first time we've bothered. Normally we just silently break the C API, unless it's libLTO or libIndex -- those were designed to be able to keep working as we change LLVM and Clang. LLVMGetNumOperands et al were not.

Ah, that's good context.  Thanks.

>> Either way, are you comfortable with the updated patch?  I still see it
>> as an improvement over ToT, and it unblocks my use-list order work.
> 
> Yep, got it. Go right ahead.

r215457.




More information about the llvm-commits mailing list