[PATCH] Debug info: Support fragmented variables.

Adrian Prantl aprantl at apple.com
Fri Aug 8 14:16:51 PDT 2014


Ah! In the drop down menu above the comment box. Thanks,
Adrian

> On Aug 8, 2014, at 2:09 PM, David Blaikie <dblaikie at gmail.com> wrote:
> 
> As the owner of a code review you can "Abandon" it as one of the
> possible actions. I think that's the right thing.
> 
> On Fri, Aug 8, 2014 at 2:03 PM, Adrian Prantl <aprantl at apple.com> wrote:
>> Done. But how do I kill the old one in Phab?
>> 
>> -- adrian
>> 
>>> On Aug 8, 2014, at 1:43 PM, David Blaikie <dblaikie at gmail.com> wrote:
>>> 
>>> On Fri, Aug 8, 2014 at 1:07 PM, Adrian Prantl <aprantl at apple.com> wrote:
>>>> The type legalizer changes can be found at http://reviews.llvm.org/D4831.
>>> 
>>> If it's not too much hassle, you could recreate this Phab review, but
>>> include at least llvm-commits (but ideally the other people you added
>>> to the review/sub line) when you /create/ the review, that way the
>>> initial email from Phab will go to the mailing list, with the patch
>>> attached, etc. As it is now, no email has been sent to the list and
>>> the first reply from any of us will email the list but the list won't
>>> have the original email (or patch attachment) to refer to... :/ it's
>>> kind of annoying, I know.
>>> 
>>> If that's too much hassle you might just be able to reply to the email
>>> Phab initially sent you (I assume you got the inital CR email) and
>>> attach the patch/CC the list/people/etc manually. Won't thread
>>> perfectly, but well enough.
>>> 
>>>> 
>>>> http://reviews.llvm.org/D2680
>>>> 
>>>> 
>> 




More information about the llvm-commits mailing list