[PATCH] MC: Split the x86 asm matcher implementations by dialect

Jim Grosbach grosbach at apple.com
Fri Aug 8 13:31:38 PDT 2014


I believe Daniel's right that WasOriginallyInvalidOperand is unused and can be nuked in MatchAndEmitIntelInstruction().

Do we already have testcases for the various other forms? I'm specifically thinking of the retry loop "for (unsigned Size : MopSizes) {".

================
Comment at: test/MC/X86/intel-syntax-ambiguous.s:11
@@ +10,3 @@
+inc word ptr [eax]
+inc byte ptr [eax]
+// CHECK-NOT: error:
----------------
We should check the encoding of these instructions, not just that we can parse them without error.

http://reviews.llvm.org/D4747






More information about the llvm-commits mailing list