[PATCH] [AArch64] FP load balancing pass for Cortex-A57

Tim Northover t.p.northover at gmail.com
Fri Aug 8 02:42:50 PDT 2014


Just added llvm-commits.

================
Comment at: lib/Target/AArch64/AArch64A57FPLoadBalancing.cpp:318
@@ +317,3 @@
+  // "link" register between each inst in the chain.
+  std::map<unsigned, Chain*> ActiveChains;
+  std::set<Chain*> AllChains;
----------------
Tim Northover wrote:
> Aren't these chains leaked? It *looks* like you could make this (or the set) a unique_ptr<Chain>.
Also, this should definitely be the set. I hadn't noticed things get removed from ActiveChains when I wrote this. Should have been obvious, in retrospect.

http://reviews.llvm.org/D4791






More information about the llvm-commits mailing list