[llvm] r214724 - Add features for PPC 4xx and e500/e500mc instructions.

Chandler Carruth chandlerc at google.com
Thu Aug 7 03:35:49 PDT 2014


On Thu, Aug 7, 2014 at 3:24 AM, Joerg Sonnenberger <joerg at britannica.bec.de>
wrote:

> On Wed, Aug 06, 2014 at 11:35:03PM -0500, Hal Finkel wrote:
> > > +def FeatureE500      : SubtargetFeature<"E500", "IsE500", "true",
> >
> > I'd prefer to keep the capitalization convention uniform across all of
> > the subtarget features. Currently, none of them are capitalized (which
> > I believe matches other targets), so this should be "e500".
>
> I'm not attached to that, so feel free to adjust it.


This is code review for your patch, it's your responsibility to address it,
not Hal's...
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140807/16c23fa9/attachment.html>


More information about the llvm-commits mailing list