[PATCH] fix a test that has no checks

Sanjay Patel spatel at rotateright.com
Wed Aug 6 13:55:29 PDT 2014


REPOSITORY
  rL LLVM

================
Comment at: test/CodeGen/X86/vec_fneg.ll:8
@@ +7,3 @@
+; CHECK-LABEL: t1:
+; CHECK: xorps	{{.*}}LCPI0_0{{.*}}, %xmm0
+; CHECK-NEXT: retl
----------------
Chandler Carruth wrote:
> I suspect you're going to have trouble getting this to portably match. I would use a triple such as the bare metal 'x86_64-unknown-unknown' one to get a more stable pattern.
> 
> What we really should do is add comprehensive verbose asm comments that expand constant pool operands in the comment so that we can file check them in-line.
> 
> You can see some of how to do this with my changes to X86MCInstLower.cpp for comments on PSHUFB instructions if your interested... But it'll be somewhat complex. Clearly no need to do that for this patch.
Thanks for the suggestion. I'll just use a triple for now rather than -march/-mattr.

I'm all for improving the asm comments - a few weeks ago, I filed:
http://llvm.org/bugs/show_bug.cgi?id=20347

I'll see if I can make any progress there.

http://reviews.llvm.org/D4812






More information about the llvm-commits mailing list