[PATCH] tsan: allocate vector clocks using slab allocator

[Alexey Samsonov]

================
Comment at: lib/sanitizer_common/sanitizer_thread_registry.cc:221
@@ -220,2 +220,3 @@
 
 void ThreadRegistry::DetachThread(u32 tid) {
+  DetachThread(tid, 0);
----------------
Can you get rid of this overload completely?

================
Comment at: lib/tsan/rtl/tsan_clock.cc:15
@@ -14,2 +14,3 @@
 #include "tsan_rtl.h"
+#include "sanitizer_common/sanitizer_placement_new.h"
 
----------------
Why do you need this #include?

================
Comment at: lib/tsan/rtl/tsan_clock.cc:372
@@ +371,3 @@
+SyncClock::SyncClock() {
+  tab_ = 0;
+  tab_idx_ = 0;
----------------
Any particular reason for not using initializer list here?

================
Comment at: lib/tsan/rtl/tsan_clock.h:47
@@ -29,2 +46,3 @@
   SyncClock();
+  ~SyncClock();
 
----------------
IIUC Reset() should be called manually before destructor. If that is really required, can you at least describe it in the comment or elsewhere.

================
Comment at: lib/tsan/rtl/tsan_clock.h:124
@@ -96,2 +123,3 @@
   void UpdateCurrentThread(SyncClock *dst) const;
+  void Resize(ClockCache *c, SyncClock *dst) const;
 };
----------------
Why isn't this method called SyncClock::Resize(ClockCache *c, uptr nclk); ?

http://reviews.llvm.org/D4794