[PATCH] cmake: Remove check for files not in build list.

[Chandler Carruth]

I agree as well. We should make it work well, but we should keep the
functionality.


On Sun, Aug 3, 2014 at 8:30 PM, Duncan P. N. Exon Smith <
dexonsmith at apple.com> wrote:

> +1
>
> It make sense to ignore temp files, but I also find this useful.
>
> > On 2014 Aug 1, at 10:34, Owen Anderson <resistor at mac.com> wrote:
> >
> > I find this functionality very handy in sanity-checking that I’ve
> remembered to add new files to the build system.  I’d argue strongly
> against removing it.  Could it be amended to ignore common backup file
> patterns?
> >
> > —Owen
> >
> > On Jul 17, 2014, at 11:59 PM, Matt Arsenault <Matthew.Arsenault at amd.com>
> wrote:
> >
> >> I don't see what value this provides. It does globbing for
> >> files to build, and still requires manually listing the files.
> >> emacs by default creates backup files in the same directory if you
> >> make changes without saving, resulting in really irritating
> >> build errors from the "found unknown source file .#Foo.cpp"
> >>
> >> I also don't think it's consistently used, since this
> >> doesn't seems to happen for some subset of directories.
> >>
> >> http://reviews.llvm.org/D4581
> >>
> >> Files:
> >> cmake/modules/LLVMProcessSources.cmake
> >>
> >> Index: cmake/modules/LLVMProcessSources.cmake
> >> ===================================================================
> >> --- cmake/modules/LLVMProcessSources.cmake
> >> +++ cmake/modules/LLVMProcessSources.cmake
> >> @@ -41,7 +41,6 @@
> >> function(llvm_process_sources OUT_VAR)
> >>  cmake_parse_arguments(ARG "" "" "ADDITIONAL_HEADERS" ${ARGN})
> >>  set(sources ${ARG_UNPARSED_ARGUMENTS})
> >> -  llvm_check_source_file_list( ${sources} )
> >>  if( MSVC_IDE OR XCODE )
> >>    # This adds .td and .h files to the Visual Studio solution:
> >>    add_td_sources(sources)
> >> @@ -52,20 +51,3 @@
> >>
> >>  set( ${OUT_VAR} ${sources} PARENT_SCOPE )
> >> endfunction(llvm_process_sources)
> >> -
> >> -
> >> -function(llvm_check_source_file_list)
> >> -  set(listed ${ARGN})
> >> -  file(GLOB globbed *.c *.cpp)
> >> -  foreach(g ${globbed})
> >> -    get_filename_component(fn ${g} NAME)
> >> -    list(FIND LLVM_OPTIONAL_SOURCES ${fn} idx)
> >> -    if( idx LESS 0 )
> >> -      list(FIND listed ${fn} idx)
> >> -      if( idx LESS 0 )
> >> -        message(SEND_ERROR "Found unknown source file ${g}
> >> -Please update ${CMAKE_CURRENT_LIST_FILE}\n")
> >> -      endif()
> >> -    endif()
> >> -  endforeach()
> >> -endfunction(llvm_check_source_file_list)
> >> <D4581.11635.patch>_______________________________________________
> >> llvm-commits mailing list
> >> llvm-commits at cs.uiuc.edu
> >> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> >
> >
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140803/480a9bc9/attachment.html>