[Polly] Annotate reduction dependences

Johannes Doerfert doerfert at cs.uni-saarland.de
Fri Aug 1 00:01:17 PDT 2014


I split the old patch again and attached all parts to this mail.

I also tried to include your comments. However, the print method looks different
now (because of the printLine patch) so I had to rewrite this part. The second
patch (is*Parallel change) was a result if this rewriting, but is also a step
closer to the goal of allowing reductions in the backend.


On 07/30, Tobias Grosser wrote:
> Can you add a little information into the commit message regarding why this
> is useful and what it is doing. With this commit message, nobody who does
> not know what you are doing gets this from a quick look.
Changed (at least tried to).

> >+  isl_union_map *RED_SIN = isl_union_map_empty(isl_union_map_get_space(RAW));
> >+  for (ScopStmt *Stmt : S) {
> >+    for (MemoryAccess *MA : *Stmt) {
> >+      if (!MA->isReductionLike())
> >+        continue;
> >+
> >+      isl_set *AccDomW = isl_map_wrap(MA->getAccessRelation());
> >+      isl_union_map *AccRedDepU = isl_union_map_intersect_domain(
> >+          isl_union_map_copy(TC_RED), isl_union_set_from_set(AccDomW));
> >+      if (isl_union_map_is_empty(AccRedDepU) && !isl_union_map_free(AccRedDepU))
> 
> What is the free doing in the if? Is this a clever way to avoid braces?
Yes.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Change-the-printing-of-reduction-types.patch
Type: text/x-diff
Size: 13294 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140801/2c022bbb/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Change-the-semantics-of-is-Parallel.patch
Type: text/x-diff
Size: 3840 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140801/2c022bbb/attachment-0001.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Annotate-the-IslAst-with-broken-reductions.patch
Type: text/x-diff
Size: 20660 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140801/2c022bbb/attachment-0002.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 213 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140801/2c022bbb/attachment.sig>


More information about the llvm-commits mailing list