[PATCH] MC: Split the x86 asm matcher implementations by dialect

Reid Kleckner rnk at google.com
Thu Jul 31 15:11:29 PDT 2014


Hi grosbach,

The existing matcher has lots of AT&T assembly dialect assumptions baked
into it.  In particular, the hack for resolving the size of a memory
operand by appending the four most common suffixes doesn't work at all.
The Intel assembly dialect mnemonic table has ambiguous entries, so we
need to try matching multiple times with different operand sizes, since
that's the only way to choose different instruction variants.

This makes us more compatible with gas's implementation of Intel
assembly syntax.  MSVC assumes you want byte-sized operations for the
instructions that we reject as ambiguous.

http://reviews.llvm.org/D4747

Files:
  lib/Target/X86/AsmParser/X86AsmParser.cpp
  lib/Target/X86/AsmParser/X86Operand.h
  test/MC/X86/intel-syntax-ambiguous.s
  test/MC/X86/intel-syntax-ptr-sized.s
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D4747.12087.patch
Type: text/x-patch
Size: 14434 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140731/a5ca7375/attachment.bin>


More information about the llvm-commits mailing list