[llvm] r214213 - UseListShuffleVector: Remove copy constructor

[David Blaikie]

Might be nice to have a unit test to exercise/verify the functionality
on other machines, and/or a comment about why it's needed. (yeah, the
comment may become outdated quickly if/as other uses are introduced,
I'm not sure)

On Tue, Jul 29, 2014 at 5:35 PM, Duncan P. N. Exon Smith
<dexonsmith at apple.com> wrote:
>
>> On 2014-Jul-29, at 17:14, Duncan P. N. Exon Smith <dexonsmith at apple.com> wrote:
>>
>>>
>>> On 2014-Jul-29, at 15:36, David Blaikie <dblaikie at gmail.com> wrote:
>>>
>>> On Tue, Jul 29, 2014 at 1:45 PM, Duncan P. N. Exon Smith
>>> <dexonsmith at apple.com> wrote:
>>>> Author: dexonsmith
>>>> Date: Tue Jul 29 15:45:52 2014
>>>> New Revision: 214213
>>>>
>>>> URL: http://llvm.org/viewvc/llvm-project?rev=214213&view=rev
>>>> Log:
>>>> UseListShuffleVector: Remove copy constructor
>>>>
>>>> Remove the copy constructor added in r214178 to appease MSVC17 since it
>>>> shouldn't be called at all.  My guess is that explicitly deleting it
>>>> will make the compiler happy.  To round out the operations I've also
>>>> deleted copy assignment and added move assignment.  Otherwise no
>>>> functionality change.
>>>
>>> If you're not using nor unit testing move assignment (or other
>>> operations), I'd probably just leave it out (possibly explicitly
>>> deleted with a comment about how someone can add it when they need
>>> it), though I'm not adamant about this.
>>
>> I agree; r214260.
>
> Turns out MSVC uses move assignment here [1].  Reverted in r214264.
>
> [1]: http://bb.pgr.jp/builders/ninja-clang-i686-msc17-R/builds/9631