[llvm] r214240 - Feedback on r214189, no functionality change.

Manman Ren manman.ren at gmail.com
Tue Jul 29 15:58:13 PDT 2014


Author: mren
Date: Tue Jul 29 17:58:13 2014
New Revision: 214240

URL: http://llvm.org/viewvc/llvm-project?rev=214240&view=rev
Log:
Feedback on r214189, no functionality change.

Modified:
    llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
    llvm/trunk/lib/CodeGen/AsmPrinter/DwarfUnit.cpp
    llvm/trunk/lib/IR/DIBuilder.cpp

Modified: llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp?rev=214240&r1=214239&r2=214240&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp (original)
+++ llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp Tue Jul 29 17:58:13 2014
@@ -473,7 +473,7 @@ DIE *DwarfDebug::createScopeChildrenDIE(
     // If we have more than one elements and the last one is null, it is a
     // variadic function.
     if (FnArgs.getNumElements() > 1 &&
-        !resolve(FnArgs.getElement(FnArgs.getNumElements() - 1)))
+        !FnArgs.getElement(FnArgs.getNumElements() - 1))
       Children.push_back(
           make_unique<DIE>(dwarf::DW_TAG_unspecified_parameters));
   }

Modified: llvm/trunk/lib/CodeGen/AsmPrinter/DwarfUnit.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfUnit.cpp?rev=214240&r1=214239&r2=214240&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/AsmPrinter/DwarfUnit.cpp (original)
+++ llvm/trunk/lib/CodeGen/AsmPrinter/DwarfUnit.cpp Tue Jul 29 17:58:13 2014
@@ -1168,7 +1168,7 @@ void DwarfUnit::constructTypeDIE(DIE &Bu
 
     bool isPrototyped = true;
     if (Elements.getNumElements() == 2 &&
-        !resolve(Elements.getElement(1)))
+        !Elements.getElement(1))
       isPrototyped = false;
 
     constructSubprogramArguments(Buffer, Elements);

Modified: llvm/trunk/lib/IR/DIBuilder.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/IR/DIBuilder.cpp?rev=214240&r1=214239&r2=214240&view=diff
==============================================================================
--- llvm/trunk/lib/IR/DIBuilder.cpp (original)
+++ llvm/trunk/lib/IR/DIBuilder.cpp Tue Jul 29 17:58:13 2014
@@ -876,7 +876,7 @@ void DIBuilder::retainType(DIType T) {
 /// createUnspecifiedParameter - Create unspeicified type descriptor
 /// for the subroutine type.
 DIBasicType DIBuilder::createUnspecifiedParameter() {
-  return DIBasicType(nullptr);
+  return DIBasicType();
 }
 
 /// createForwardDecl - Create a temporary forward-declared type that





More information about the llvm-commits mailing list