[PATCH] R600/SI: Implement getOptimalMemOpType

Matt Arsenault arsenm2 at gmail.com
Mon Jul 28 10:45:34 PDT 2014


On Jul 28, 2014, at 7:04 AM, Tom Stellard <tom at stellard.net> wrote:

> On Sat, Jul 26, 2014 at 09:19:36PM +0000, Matt Arsenault wrote:
>> The default guess uses i32. This really needs an address space argument to really do the right thing in all cases.
>> 
>> http://reviews.llvm.org/D4683
>> 
>> Files:
>>  lib/Target/R600/SIISelLowering.cpp
>>  lib/Target/R600/SIISelLowering.h
>>  test/CodeGen/R600/llvm.memcpy.ll
> 
> This patch LGTM, but I've disabled memcpy for R600, so clang and the optimization
> passes shouldn't be generating it.
> 
> -Tom
> 
This isn’t entirely true. Clang still emits memcpy for some struct assignments





More information about the llvm-commits mailing list