[PATCH][AArch64] Prefer ldp x, x to ldr q

Chad Rosier mcrosier at codeaurora.org
Mon Jul 28 08:36:28 PDT 2014


James,
I'm probably not the best to review these, but these look pretty straight
forward.

Also, I believe you used Tim's old address.  Forwarding to Tim's current
address.

 Chad

> Hi Tim,
>
>
>
> "LDR Qn" instructions are no more performant (on any microarchitecture I
> know of) than "LDP Xm, Xn" or "LDP Dm, Dn". In fact, there are no
> callee-saved Q registers so generating "LDR Qn" can cause serious
> performance problems, as it is immediately spilled.
>
>
>
> These are generated in two places - DAGCombine and SLP vectorize. Attached
> are two simple patches to disable these transformations for AArch64
> (actually if TLI->hasPairedLoad() which seems to have been made for this
> purpose).
>
>
>
> Are they OK?
>
>
>
> Cheers,
>
>
>
> James
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>




More information about the llvm-commits mailing list