[compiler-rt] r209282 - [asan] Fix x86 asm instrumentation to preserve flags.

İsmail Dönmez ismail at donmez.ws
Mon Jul 28 00:15:35 PDT 2014


Hi,


On Wed, May 21, 2014 at 11:21 AM, Evgeniy Stepanov <
eugeni.stepanov at gmail.com> wrote:

> Author: eugenis
> Date: Wed May 21 03:21:14 2014
> New Revision: 209282
>
> URL: http://llvm.org/viewvc/llvm-project?rev=209282&view=rev
> Log:
> [asan] Fix x86 asm instrumentation to preserve flags.
>
> This change also enables asm instrumentation in asan tests that was
> accidentally disabled yearlier, and adds a sanity test for that.
>
> Patch by Yuri Gorshenin.
>
>
> Modified:
>     compiler-rt/trunk/lib/asan/asan_asm_instrumentation.S
>     compiler-rt/trunk/lib/asan/scripts/gen_asm_instrumentation.sh
>     compiler-rt/trunk/lib/asan/tests/CMakeLists.txt
>     compiler-rt/trunk/lib/asan/tests/asan_asm_test.cc
>
>
This doesn't seem to work on ARM/Linux, -asan-instrument-assembly option
unknown:

[/havana/sources/llvm/build]> ninja -j1 check-all
[2/32] Generating ASAN_INST_TEST_OBJECTS.asan_globals_test.cc.arm-inline.o
FAILED: cd /havana/sources/llvm/build/projects/compiler-rt/lib/asan/tests
&& /havana/sources/llvm/build/./bin/clang -mfloat-abi=hard -mtune=cortex-a8
-mfpu=neon -fPIC -fvisibility-inlines-hidden -Wall -W -Wno-unused-parameter
-Wwrite-strings -Wmissing-field-initializers -pedantic -Wno-long-long
-Wcovered-switch-default -Wnon-virtual-dtor -std=c++11 -fcolor-diagnostics
-ffunction-sections -fdata-sections -Wall -std=c++11
-Wno-unknown-warning-option -DGTEST_NO_LLVM_RAW_OSTREAM=1
-DGTEST_HAS_RTTI=0 -I/havana/sources/llvm/utils/unittest/googletest/include
-I/havana/sources/llvm/utils/unittest/googletest
-I/havana/sources/llvm/projects/compiler-rt/include
-I/havana/sources/llvm/projects/compiler-rt/lib
-I/havana/sources/llvm/projects/compiler-rt/lib/asan
-I/havana/sources/llvm/projects/compiler-rt/lib/sanitizer_common/tests
-fno-rtti -O2 -Wno-format -Werror=sign-compare -Wno-variadic-macros
-gline-tables-only -DASAN_HAS_BLACKLIST=1 -DASAN_HAS_EXCEPTIONS=1
-DASAN_UAR=0 -fsanitize=address
-fsanitize-blacklist=/havana/sources/llvm/projects/compiler-rt/lib/asan/tests/asan_test.ignore
-mllvm -asan-instrument-assembly -march=armv7-a -c -o
ASAN_INST_TEST_OBJECTS.asan_globals_test.cc.arm-inline.o
/havana/sources/llvm/projects/compiler-rt/lib/asan/tests/asan_globals_test.cc
clang (LLVM option parsing): Unknown command line argument
'-asan-instrument-assembly'.  Try: 'clang (LLVM option parsing) -help'
clang (LLVM option parsing): Did you mean '-asan-instrument-atomics'?
ninja: build stopped: subcommand failed.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140728/90bebb40/attachment.html>


More information about the llvm-commits mailing list