[PATCH] Ephemeral values for LLVM invariants

hfinkel at anl.gov hfinkel at anl.gov
Sun Jul 27 21:02:11 PDT 2014

Comment at: lib/Analysis/IPA/InlineCost.cpp:899
@@ +898,3 @@
+    // Skip ephemeral values.
+    if (EphValues.count(I))
+      continue;
Philip Reames wrote:
> It looks like the previous check is now redundant with this one?  It might be worth leaving it in place for clarity, but if so, an explicit comment might be warranted.  
It is redundant, only if the EphValues set is fully populated. I don't want the rest of the infrastructure to depend on that (at least for now). I'll add a comment.


More information about the llvm-commits mailing list