[PATCH] Document new LLVM CMake interface and emit warning when using llvm_map_components_to_libraries
dan at su-root.co.uk
Sat Jul 26 12:50:27 PDT 2014
Are you okay with the patches and are you okay with the interface
change ( llvm_map_components_to_libraries ->
Also as you may of read I proposed just simply dropping
llvm_map_components_to_libraries and the renaming
llvm_map_components_to_libnames so users of LLVM don't have to change
their CMake scripts. This is not what is currently in trunk/release_35
and my patches do not change this.
On 23 July 2014 20:26, Brad King <brad.king at kitware.com> wrote:
> On 07/23/2014 03:18 PM, Dan Liew wrote:
>>> Use the type PATH rather than STRING so cmake-gui will use a
>>> file-chooser dialog to edit the value interactively. Or you
>>> can just leave off the type: ``-DLLVM_DIR=/usr/share/llvm/cmake/``
>>> and the find_package command should set the type for you.
>> Hmm I don't usually pass variables to cmake-gui.
> Sorry, I meant if you construct a build tree on the command line
> and then later edit it with cmake-gui. Anyway, we can leave off
> the type in the example.
>> I've change the docs to use ``-DLLVM_DIR=``
> Thanks. I see: ``-DLLVM_DIR=/usr/share/llvm/cmake/``, but please drop
> the trailing slash. That was a typo in my previous message. Sorry.
>> I presume the attached patches are okay to commit once I've heard back
>> from Takumi?
> Yes, thanks.
PhD Student - Imperial College London
More information about the llvm-commits