[compiler-rt] r214012 - builtins: make the x86_64 compatible with GAS

Saleem Abdulrasool compnerd at compnerd.org
Fri Jul 25 21:03:59 PDT 2014


Author: compnerd
Date: Fri Jul 25 23:03:59 2014
New Revision: 214012

URL: http://llvm.org/viewvc/llvm-project?rev=214012&view=rev
Log:
builtins: make the x86_64 compatible with GAS

The .rodata directive was added on the IA-64 (Itanium) platform.  The LLVM IAS
supports the .rodata on i386 and x86_64 as well.  There is no reason to really
restrict compilation of the builtins to just clang.  By explicitly indicating
that the data is meant to be pushed into the .rodata section via the .section
.rodata, the assembly is made compatible with clang and gcc (with GAS).

This will enable building these routines on the Linux buildbots via CMake.

Modified:
    compiler-rt/trunk/lib/builtins/x86_64/floatundidf.S
    compiler-rt/trunk/lib/builtins/x86_64/floatundisf.S
    compiler-rt/trunk/lib/builtins/x86_64/floatundixf.S

Modified: compiler-rt/trunk/lib/builtins/x86_64/floatundidf.S
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/builtins/x86_64/floatundidf.S?rev=214012&r1=214011&r2=214012&view=diff
==============================================================================
--- compiler-rt/trunk/lib/builtins/x86_64/floatundidf.S (original)
+++ compiler-rt/trunk/lib/builtins/x86_64/floatundidf.S Fri Jul 25 23:03:59 2014
@@ -20,7 +20,7 @@
 #if defined(__APPLE__)
 	.const
 #elif defined(__ELF__)
-	.rodata
+	.section .rodata
 #else
 	.section .rdata,"rd"
 #endif

Modified: compiler-rt/trunk/lib/builtins/x86_64/floatundisf.S
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/builtins/x86_64/floatundisf.S?rev=214012&r1=214011&r2=214012&view=diff
==============================================================================
--- compiler-rt/trunk/lib/builtins/x86_64/floatundisf.S (original)
+++ compiler-rt/trunk/lib/builtins/x86_64/floatundisf.S Fri Jul 25 23:03:59 2014
@@ -10,7 +10,7 @@
 #if defined(__APPLE__)
 	.literal4
 #elif defined(__ELF__)
-	.rodata
+	.section .rodata
 #else
 	.section .rdata,"rd"
 #endif

Modified: compiler-rt/trunk/lib/builtins/x86_64/floatundixf.S
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/builtins/x86_64/floatundixf.S?rev=214012&r1=214011&r2=214012&view=diff
==============================================================================
--- compiler-rt/trunk/lib/builtins/x86_64/floatundixf.S (original)
+++ compiler-rt/trunk/lib/builtins/x86_64/floatundixf.S Fri Jul 25 23:03:59 2014
@@ -10,7 +10,7 @@
 #if defined(__APPLE__)
 	.const
 #elif defined(__ELF__)
-	.rodata
+	.section .rodata
 #else
 	.section .rdata,"rd"
 #endif





More information about the llvm-commits mailing list