[llvm] r213923 - [X86] Add comments to clarify some non-obvious lines in the stackmap-nops.ll

Lang Hames lhames at gmail.com
Thu Jul 24 21:50:08 PDT 2014


Author: lhames
Date: Thu Jul 24 23:50:08 2014
New Revision: 213923

URL: http://llvm.org/viewvc/llvm-project?rev=213923&view=rev
Log:
[X86] Add comments to clarify some non-obvious lines in the stackmap-nops.ll
testcases.

Based on code review from Philip Reames. Thanks Philip!


Modified:
    llvm/trunk/test/CodeGen/X86/stackmap-nops.ll
    llvm/trunk/test/MC/X86/stackmap-nops.ll

Modified: llvm/trunk/test/CodeGen/X86/stackmap-nops.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/stackmap-nops.ll?rev=213923&r1=213922&r2=213923&view=diff
==============================================================================
--- llvm/trunk/test/CodeGen/X86/stackmap-nops.ll (original)
+++ llvm/trunk/test/CodeGen/X86/stackmap-nops.ll Thu Jul 24 23:50:08 2014
@@ -224,6 +224,9 @@ entry:
   tail call void (i64, i32, ...)* @llvm.experimental.stackmap(i64 28, i32 28)
   tail call void (i64, i32, ...)* @llvm.experimental.stackmap(i64 29, i32 29)
   tail call void (i64, i32, ...)* @llvm.experimental.stackmap(i64 30, i32 30)
+; Add an extra stackmap with a zero-length shadow to thwart the shadow
+; optimization. This will force all 15 bytes of the previous shadow to be
+; padded with nops.
   tail call void (i64, i32, ...)* @llvm.experimental.stackmap(i64 31, i32 0)
   ret void
 }

Modified: llvm/trunk/test/MC/X86/stackmap-nops.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/X86/stackmap-nops.ll?rev=213923&r1=213922&r2=213923&view=diff
==============================================================================
--- llvm/trunk/test/MC/X86/stackmap-nops.ll (original)
+++ llvm/trunk/test/MC/X86/stackmap-nops.ll Thu Jul 24 23:50:08 2014
@@ -41,6 +41,9 @@ entry:
   tail call void (i64, i32, ...)* @llvm.experimental.stackmap(i64 13, i32 13)
   tail call void (i64, i32, ...)* @llvm.experimental.stackmap(i64 14, i32 14)
   tail call void (i64, i32, ...)* @llvm.experimental.stackmap(i64 15, i32 15)
+; Add an extra stackmap with a zero-length shadow to thwart the shadow
+; optimization. This will force all 15 bytes of the previous shadow to be
+; padded with nops.
   tail call void (i64, i32, ...)* @llvm.experimental.stackmap(i64 16, i32 0)
   ret void
 }





More information about the llvm-commits mailing list