[llvm] r213892 - [X86] Optimize stackmap shadows on X86.

Lang Hames lhames at gmail.com
Thu Jul 24 16:06:43 PDT 2014

They're essentially unrelated. I moved the other Lower* methods
(LowerSTACKMAP, LowerPATCHPOINT) in to X86AsmPrinter, and did the same for
LowerTlsAddr for consistency. I forgot to back this cosmetic change to
LowerTlsAddr out before I committed. My apologies for that.

There is no functional change due to the signature change of LowerTlsAddr,
so it can be safely reverted if you would prefer. The changes to the body
of LowerTlsAddr should remain if possible though - they are valuable
(though not strictly necessary) for the optimization.

- Lang.

On Thu, Jul 24, 2014 at 2:36 PM, Philip Reames <listmail at philipreames.com>

> Was there a review thread for this I missed?  I would have liked to see
> this before it went in.
> On 07/24/2014 01:40 PM, Lang Hames wrote:
>>     case X86::TLS_base_addr64:
>> -    return LowerTlsAddr(OutStreamer, MCInstLowering, *MI,
>> getSubtargetInfo());
>> +    return LowerTlsAddr(MCInstLowering, *MI);
> This looks like it might be an accidental unrelated change?
> Philip
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140724/384fe688/attachment.html>

More information about the llvm-commits mailing list