[patch] Add support for .exitm in the integrated assembler

Saleem Abdulrasool compnerd at compnerd.org
Thu Jul 24 09:32:06 PDT 2014

On Wed, Jul 23, 2014 at 10:59 PM, Nico Weber <thakis at chromium.org> wrote:

> Hi,
> the attached patch adds support for .exitm as documented on
> https://sourceware.org/binutils/docs/as/Exitm.html#Exitm , PR20426.
> Everything from the current macro expansion after .exitm is ignored; this
> matches gas's behavior.
> (It also removes the unused TheMacro member from MacroInstantiation.)

Can you split this up into two patches.  Removing the unused member
variable is fine, but Id rather that be a separate change.

Unnecessary braces in parseDirectiveExitMacro around the

It feels like the tests for the .exitm could be simplified further.

.exitm is encountered in a normal macro expansion
.exitm is in a true branch
.exitm is in a false branch
.exitm is in a false branch that is encountered prior to the true branch

> Please take a look!
> Nico
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

Saleem Abdulrasool
compnerd (at) compnerd (dot) org
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140724/d6788ffa/attachment.html>

More information about the llvm-commits mailing list