[PATCH] [x86] Make vector legalization of extloads work more like the "normal" vector operation legalization with support for custom target lowering and fallback to expand when it fails, and use this to implement sext and anyext load lowering for x86 in a...

hfinkel at anl.gov hfinkel at anl.gov
Thu Jul 24 06:19:18 PDT 2014

Comment at: lib/Target/X86/X86ISelLowering.cpp:12914
@@ +12913,3 @@
+        SDValue(Ld, 1),
+        DAG.getNode(ISD::TokenFactor, dl, MVT::Other, Load.getValue(1)));
Chandler Carruth wrote:
> hfinkel at anl.gov wrote:
> > Why are you creating a TokenFactor with one operand? Can't you just use the chain directly?
> \meme{i have no idea what i'm doing}
> Are you saying I should RAUW the old chain value with the chain value of the load? That makes sense if so, and I'll do so.
(but you're learning ;) )

Yes, that's what I'm saying.


More information about the llvm-commits mailing list