[PATCH] [sanitizer_common] Refactor SuspendedThreadsList to let it be used with different thread ID types

Sergey Matveev earthdok at google.com
Thu Jul 24 05:39:57 PDT 2014


What does this patch do that couldn't be achieved with the following change:

diff --git a/lib/sanitizer_common/sanitizer_stoptheworld.h b/lib/sanitizer_common/sanitizer_stoptheworld.h
index a326467..46619c9 100644
--- a/lib/sanitizer_common/sanitizer_stoptheworld.h
+++ b/lib/sanitizer_common/sanitizer_stoptheworld.h
@@ -18,7 +18,11 @@
 #include "sanitizer_common.h"
 
 namespace __sanitizer {
+#if SANITIZER_LINUX
 typedef int SuspendedThreadID;
+#elif SANITIZER_MAC
+typedef macos_thread_t SuspendedThreadID;
+#endif
 
 // Holds the list of suspended threads and provides an interface to dump their
 // register contexts.

http://reviews.llvm.org/D4639






More information about the llvm-commits mailing list