[llvm] r212248 - Invert the MC -> Object dependency.

Jim Grosbach grosbach at apple.com
Wed Jul 23 15:10:29 PDT 2014


Looks reasonable to me.

-Jim

> On Jul 23, 2014, at 7:57 AM, Rafael EspĂ­ndola <rafael.espindola at gmail.com> wrote:
> 
>>> Invert the MC -> Object dependency.
>> 
>> 
>> This dependency inversion wasn't entirely successful (and has broken the
>> modules build): MC still depends on Object. In particular:
>> 
>> $ rgrep '#include "llvm/Object' MC
>> MC/MCObjectSymbolizer.h:#include "llvm/Object/ObjectFile.h"
> 
> Sorry I missed that. I think the attached patch should fix it.
> Grosbach, do you think that moving these files is the right fix?
> 
> Cheers,
> Rafael
> <t.patch>





More information about the llvm-commits mailing list