[PATCH] TableGen: Expand error message for duplicate records in FastISel

David Wiberg dwiberg at gmail.com
Wed Jul 23 14:29:29 PDT 2014


I suggest expanding the error message received from the fast ISel
emitter for duplicate records. This will help the user better
understand what is wrong and find the records involved.

Example of error message with the patch:
C:/dev/llvm-git/llvm/lib/Target/PowerPC\PPCInstrVLE.td:428:3: error:
Duplicate record in FastISel table!
Records 'E_ADDI' and 'SE_ADD' have the same pattern and predicates.
  def E_ADDI : SCI8Form<6, 8, (outs gprc:$rT), (ins gprc:$rA, sci8:$imm),

The change was inspired by a message on the list [1] which helped me
understand an error that I made. When browsing other error messages I
noticed that most consists of only a single sentence so perhaps this
might need adjusting. The important part for me is to show the names
of both records. I do not have commit access so if this passes review
I need help with that part.

[1] http://lists.cs.uiuc.edu/pipermail/llvmdev/2014-April/072410.html

Best regards
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ExpandFastISelErrorMessage.patch
Type: text/x-patch
Size: 927 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140723/d06313fc/attachment.bin>

More information about the llvm-commits mailing list