[PATCH] [SDAG] Make the DAGCombine worklist not grow endlessly due to duplicate insertions.

Eric Christopher echristo at gmail.com
Tue Jul 22 11:55:17 PDT 2014


Couple of comments inline.

================
Comment at: test/CodeGen/X86/block-placement.ll:240
@@ -239,3 +239,1 @@
 
-define void @test_loop_rotate_reversed_blocks() {
-; This test case (greatly reduced from an Olden bencmark) ensures that the loop
----------------
Inquiring minds here? It looks like it was deleted because it's no longer applicable? Does the code look ok?

================
Comment at: test/CodeGen/X86/divide-by-constant.ll:60
@@ -58,4 +59,3 @@
 ; CHECK-LABEL: test6:
-; CHECK: imull $26215, %eax, %ecx
-; CHECK: sarl $18, %ecx
-; CHECK: shrl $15, %eax
+; CHECK: imull $26215, %eax
+; CHECK: movl %eax, %ecx
----------------
Assume the additional check lines aren't because the code generated is actually worse?

http://reviews.llvm.org/D4616






More information about the llvm-commits mailing list