[PATCH] [SDAG] Make the DAGCombine worklist not grow endlessly due to duplicate insertions.
listmail at philipreames.com
Tue Jul 22 10:08:09 PDT 2014
Overall, this seems quite reasonable. My only minor comment would be
that you should improve the naming and documentation of
recursivelyDeleteUnusedNodes. It is not currently clear from the
interface that items are added to the worklist at all, or that it is the
frontier of used nodes which are added. Given this seems to be
important from your description, it should be documented.
LGTM -- Mind you, I'm not particularly familiar with this code. So take
my LGTM with a grain or two of salt. :)
More information about the llvm-commits