[PATCH] Add LLVM_REQUIRES_EH and LLVM_REQUIRES_RTTI as options in CMake

Brad King brad.king at kitware.com
Tue Jul 22 05:38:55 PDT 2014


On 07/21/2014 04:59 PM, Dan Liew wrote:
> Okay fixed. Good to go now?

Good.  One minor tweak:

> +      message(WARNING "Exception handling requires RTTI. Enabling RTTI for ${name}")

That warning is for project authors that set LLVM_REQUIRES_EH
but not LLVM_REQUIRES_RTTI.  Since they are internal variables
there is nothing a user can do to fix this warning.  Therefore
you should use the AUTHOR_WARNING message type.

Thanks,
-Brad




More information about the llvm-commits mailing list