[PATCH] Add support for StackMap section for ELF/Linux systems

Philip Reames listmail at philipreames.com
Mon Jul 21 15:05:13 PDT 2014

On 07/21/2014 02:52 PM, Eric Christopher wrote:
> On Mon, Jul 21, 2014 at 10:08 AM, Philip Reames
> <listmail at philipreames.com> wrote:
>> ================
>> Comment at: lib/MC/MCObjectFileInfo.cpp:590
>> @@ -585,1 +589,3 @@
>> +                       SectionKind::getReadOnly());
>> +
>>   }
>> ----------------
>> Juergen Ributzka wrote:
>>> I am not familiar with the ELF sections, but wouldn't Metadata be a better for for this section. I guess it doesn't work with it, because the JIT won't ask the client to allocate it?
>>> Lang knows more about this part of the JIT.
>> Worth noting:
>> 1) The COFF section uses getMetadata
>> 2) getMetadata appears to work in practice
>> I'm happy to make the change, but don't feel like I understand the implications.  Reading through the documentation, I'm unclear on the semantics.  Lang, can you clarify?
> Philip: I'm not sure what Lang can clarify past my comments a few days
> ago. Was anything in there unclear? (Other than my question about
> whether or not the JIT will allocate anything with SHF_ALLOC - if it
> doesn't we should fix the JIT).
I had managed to miss your comment.  Sorry.

I will change to using getMetadata and update the diff.


More information about the llvm-commits mailing list