[PATCH] Add LLVM_REQUIRES_EH and LLVM_REQUIRES_RTTI as options in CMake
dan at su-root.co.uk
Mon Jul 21 06:45:29 PDT 2014
On 21 July 2014 14:13, Brad King <brad.king at kitware.com> wrote:
> On 07/20/2014 01:57 PM, Dan Liew wrote:
>> An alternative would be create options LLVM_ENABLE_RTTI and
>> LLVM_ENABLE_EH (this naming would be more similar to existing LLVM
>> option names) and reserve LLVM_REQUIRES_EH and LLVM_REQUIRES_RTTI for
>> internal use.
> This makes more sense to me. The LLVM_ENABLE_* options would provide
> defaults for the LLVM_REQUIRES_* variables when they are not otherwise
Okay. I'll rewrite the patch.
> Is the intention here to follow up by exporting LLVM_REQUIRES_*
> in LLVMConfig.cmake? That would give projects enough information
> to know how to compile in a way that is compatible with the LLVM
> libraries. IMO that is better than exporting a _FLAGS variable
> that is compiler-specific.
It was something I was considering but when I looked at the CMake code
I realised this wasn't being set globally as an option so this was a
first step in fixing it.
I think exposing information LLVM_ENABLE_RTTI and LLVM_ENABLE_EH would
be a good idea so I'll write that up as a second patch.
More information about the llvm-commits