[PATCH] Export LLVM_ENABLE_ASSERTIONS in LLVMConfig.cmake

Brad King brad.king at kitware.com
Mon Jul 21 06:13:10 PDT 2014


On 07/20/2014 06:04 AM, Dan Liew wrote:
> This patch adds LLVM_ENABLE_ASSERTIONS to LLVMConfig.cmake so clients
> know whether or not LLVM was built with assertions.

LGTM.

> I've also removed LLVM_BUILD_ENABLE_ASSERTIONS because it is
> superfluous if we have LLVM_ENABLE_ASSERTIONS. I seem to recall Brad
> King saying that the LLVM_BUILD_* variables were for Clang but when I
> looked at the Clang source I couldn't find any evidence of these
> variables being read. It seems when clang is built outside the LLVM
> source tree it gets its information from the llvm-config executable.

They were provided to allow Clang to switch to using LLVMConfig.cmake
but that never happened.  Dropping LLVM_BUILD_ENABLE_ASSERTIONS is
fine AFAIK.

-Brad




More information about the llvm-commits mailing list