[llvm] r213331 - [MCJIT] Fix the alignment requirements for ARM and AArch64 which were mistakenly

Lang Hames lhames at gmail.com
Thu Jul 17 16:11:30 PDT 2014


Author: lhames
Date: Thu Jul 17 18:11:30 2014
New Revision: 213331

URL: http://llvm.org/viewvc/llvm-project?rev=213331&view=rev
Log:
[MCJIT] Fix the alignment requirements for ARM and AArch64 which were mistakenly
relaxed in the big RuntimeDyldMachO cleanup of r213293.

No test case yet - this was found via inspection and there's no easy way to test
GOT alignment in RuntimeDyldChecker at the moment. I'm working on adding support
for this now, and hope to have a test case for this soon.


Modified:
    llvm/trunk/lib/ExecutionEngine/RuntimeDyld/Targets/RuntimeDyldMachOAArch64.h
    llvm/trunk/lib/ExecutionEngine/RuntimeDyld/Targets/RuntimeDyldMachOARM.h

Modified: llvm/trunk/lib/ExecutionEngine/RuntimeDyld/Targets/RuntimeDyldMachOAArch64.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/ExecutionEngine/RuntimeDyld/Targets/RuntimeDyldMachOAArch64.h?rev=213331&r1=213330&r2=213331&view=diff
==============================================================================
--- llvm/trunk/lib/ExecutionEngine/RuntimeDyld/Targets/RuntimeDyldMachOAArch64.h (original)
+++ llvm/trunk/lib/ExecutionEngine/RuntimeDyld/Targets/RuntimeDyldMachOAArch64.h Thu Jul 17 18:11:30 2014
@@ -24,7 +24,7 @@ public:
 
   unsigned getMaxStubSize() override { return 8; }
 
-  unsigned getStubAlignment() override { return 1; }
+  unsigned getStubAlignment() override { return 8; }
 
   relocation_iterator
   processRelocationRef(unsigned SectionID, relocation_iterator RelI,

Modified: llvm/trunk/lib/ExecutionEngine/RuntimeDyld/Targets/RuntimeDyldMachOARM.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/ExecutionEngine/RuntimeDyld/Targets/RuntimeDyldMachOARM.h?rev=213331&r1=213330&r2=213331&view=diff
==============================================================================
--- llvm/trunk/lib/ExecutionEngine/RuntimeDyld/Targets/RuntimeDyldMachOARM.h (original)
+++ llvm/trunk/lib/ExecutionEngine/RuntimeDyld/Targets/RuntimeDyldMachOARM.h Thu Jul 17 18:11:30 2014
@@ -23,7 +23,7 @@ public:
 
   unsigned getMaxStubSize() override { return 8; }
 
-  unsigned getStubAlignment() override { return 1; }
+  unsigned getStubAlignment() override { return 4; }
 
   relocation_iterator
   processRelocationRef(unsigned SectionID, relocation_iterator RelI,





More information about the llvm-commits mailing list