[PATCH] LLVM CFL Alias Analysis -- Supporting Data Structures

[Daniel Berlin]

Just some preliminary comments

================
Comment at: lib/Analysis/StratifiedSets.h:94
@@ +93,3 @@
+// it's done transparently for the user.
+//
+// In the paper above, StratifiedSets are described as a data structure wherein
----------------
For this implementation, it would be good to explain what the impact of having something above or below something else is. You later use the "below" property to ensure proper marking of externals aliasing, but without an explanation of what the impact of being below something is, it's not obvious to a reader that what you do is right.

================
Comment at: lib/Analysis/StratifiedSets.h:408
@@ +407,3 @@
+    worklist.push_back({idx1, idx2, true, true});
+
+    while (!worklist.empty()) {
----------------
An explanation of what exactly this worklist algorithm is doing, and why it is right, would be good :)

http://reviews.llvm.org/D4550