[PATCH] Generate warning when explicitly specified vectorization fails

Alp Toker alp at nuanti.com
Thu Jul 17 05:41:35 PDT 2014


On 10/07/2014 15:45, Aaron Ballman wrote:
> On Wed, Jul 9, 2014 at 10:40 PM, Tyler Nowicki <tnowicki at apple.com> wrote:
>> If these pragmas are silently ignored when then they don’t have much value.
>> A big part of their value come from the confirmation that they are working.
>> The warning will only be generated on loops with #pragma clang loop
>> vectorize/interleave/unroll specified. It can also be silenced using the
>> command line option -Wno-optimization-warning.
>>
>> I’m still looking into the clang in 32-bit mode question posed earlier. Are
>> there any other comments on the patches?
> Clang side LGTM!

We don't accept user-facing frontend patches like this without tests.

The implementation has a couple of issues too and will need another 
round of review to fit into the the backend/frontend diagnostic setup.

See 
http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20140714/110198.html 
for details.

I pinged Tyler a couple of days ago and haven't heard back, so reverted 
this commit in r213260 until the issues can be addressed.

Thanks
Alp.

>
> ~Aaron
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

-- 
http://www.nuanti.com
the browser experts




More information about the llvm-commits mailing list