[PATCH] Roundtrip the inalloca bit on allocas through bitcode

Duncan P. N. Exon Smith dexonsmith at apple.com
Tue Jul 15 18:45:35 PDT 2014


> On 2014 Jul 15, at 18:44, Reid Kleckner <rnk at google.com> wrote:
> 
> On Tue, Jul 15, 2014 at 6:39 PM, Duncan P. N. Exon Smith <dexonsmith at apple.com> wrote:
> 6 bits seems like plenty to me, but given that this is an irreversible
> bitcode change, perhaps you should send a message to llvmdev before
> committing?
> 
> This isn't really a change, we've always rejected alignments above 1<<29.  We were only doing in the .ll file parser, though, not the verifier.  I fixed that in r213027.

Ah, my mistake.  SGTM then.



More information about the llvm-commits mailing list