[PATCH] Roundtrip the inalloca bit on allocas through bitcode

Duncan P. N. Exon Smith dexonsmith at apple.com
Tue Jul 15 18:39:21 PDT 2014


> On 2014 May 28, at 15:05, Reid Kleckner <rnk at google.com> wrote:
> 
> Hi nicholas, nlewycky,
> 
> This was an oversight in the original support.  As it is, I stuffed this
> bit into the alignment.  The alignment is stored in log2 form, so it
> doesn't need more than 6 bits.  On the other hand, adding a separate
> record might be cleaner.  Hence, I'm asking for a review, since we can't
> change the decision once we make it.
> 
> http://reviews.llvm.org/D3943
> 
> Files:
>  include/llvm/Bitcode/LLVMBitCodes.h
>  lib/Bitcode/Reader/BitcodeReader.cpp
>  lib/Bitcode/Writer/BitcodeWriter.cpp
>  test/Bitcode/inalloca.ll

6 bits seems like plenty to me, but given that this is an irreversible
bitcode change, perhaps you should send a message to llvmdev before
committing?



More information about the llvm-commits mailing list