[PATCH] Perform wildcard expansion in Process::GetArgumentVector on Windows (PR17098)

David Majnemer david.majnemer at gmail.com
Tue Jul 15 16:29:13 PDT 2014


The code looks fine but it needs tests.

================
Comment at: lib/Support/Windows/Process.inc:224-225
@@ +223,4 @@
+  WIN32_FIND_DATAW FileData;
+  HANDLE FindHandle = FindFirstFileExW(Arg, FindExInfoBasic, &FileData,
+                                       FindExSearchNameMatch, NULL, 0);
+  if (FindHandle == INVALID_HANDLE_VALUE) {
----------------
Can we use `FindFirstFile`?

http://reviews.llvm.org/D4529






More information about the llvm-commits mailing list